So my new boss just affirmed that that's how it should be done. Encouraged me to not hold back. 🙌

Yes to being ruthless and obsessive on code quality. But also yes to being kind.

#Python #Dev #CodeReview #CodeQuality

I applaud #Microsoft for putting their docs on #GitHub and allowing community members to submit PRs to fix these issues, but I can't help thinking that this policy has actually backfired to a certain degree, because it gives the people responsible for writing the #docs in the first place a false sense of security and/or an excuse not to put in their best effort. I think they're too often cutting corners, pushing new #docs into production without a proper #CodeReview, and simply relying on the community to tidy up their messes. Unfortunately, though many of us in the community have the requisite knowledge to fix issues like this, those with the highest levels of knowledge naturally also have the lowest levels of free time for contributing to #OpenSource #documentation, so the issues that are likely to cause the most problems for beginner and intermediate #developers are also the least likely to be corrected by a community-submitted #PR.
2/2

#Codereview

#LegacyCode: "Hm? Ah..!? Ok?Ja?!?!"

#Java Code: "Ah...Oh....
Da könnte man auch
...
<hier zwei Stunden Diskussion über Klassengedöns, Vererbung, Interfaces,... einfügen>
...
So ist aber auch gut."

😅

Any #dev people using Checkmarx for offline Electron apps? Client request.

#work #datasecurity #codereview

Over last few years I introduced conventional comments (https://conventionalcomments.org) to multiple teams. I was happy to see how this approach improved the quality of code reviews and made people more conscious in addressing issues, questions and suggestions.
#softwaredevelopment #codereview

My first full day working on a project that uses #Gerrit (via gerrithub.io) for #GitHub #codereview and I'm pretty pleased with the workflows, and the clarity with which I can see The Things I Need To Do.
I know the team put a /lot/ of effort into tooling, workflows, and the glue to join them together, so my experience is hardly surprising, but it's still nice to be working with folks who care about that stuff; whereas many teams don't even /know/ what's possible in this space! #git

How do anyone deals with unreasonable peers during peer reviews?
Scenario: your code is efficient but implements one thing in a way no one did before and despite being well tested and without bugs it gets rejected because, hey this is how we did in the past! #developers #codeReview #peerReview

One of my biggest gripes with #codereview was the constant need to #rebase when another MR is merged.

On a high frequency project, and/or a project with long-running pipelines, this can lead to quite the impact on productivity.

Today I implemented a script into a #gitlab pipeline that automatically rebases open/non-draft MRs on merge.

#code #review #git #merge

One thing I'll often do, is review #go #golang MR/PRs that are completely out of my normal area of influence/expertise.

It helps the teams I review for, especially if they don't have much Go experience, but also gives me insight into how other teams are working with the language.

It's always optional. I don't enforce myself anywhere, I solely work with people who want me to help.

#software #engineering #softwareengineer #development #programming #review #codereview #code

This week's (or maybe month's) myth about F#:
Code without type annotations is hard to review! No, it’s a relief.
https://www.planetgeek.ch/2023/06/28/myths-about-f-code-without-type-annotations-is-hard-to-review-no-its-a-relief/

#fsharp #Myths #CodeReview

#scrum #codereview

📢New in MEAP📢

Code reviews a waste of your time?

Think again!

Adrienne Braganza lays out a unique constructive approach focused on the code rather than the developer to improve both your applications and your team dynamics: http://mng.bz/2Dva

45% off with code mlbraganza till July 5

#codereview #programming #softwaredevelopment #codinglife

Contrary to popular opinion, getting my patches reviewed after a wait of 4 years is still enjoyable.
https://gitlab.com/diggan/archiveteam-infra/-/merge_requests/1#note_1426041209

#codereview

The DHTech SIG (https://dh-tech.github.io/) just hosted an interesting discussion on #CodeReview in #DH projects. With the high amount of single-person projects it's always a challenge to get qualified code review feedback.
I wonder: Is #PairProgramming just instant code review? And if so, is there a link between code review and AI tools like GitHub #Copilot, which feels a bit like AI-driven pair programming to me? Which aspects of code reviewing / pair programming can only be provided by humans?

Hey #DHdev and #RSE folks. Do you use #codereview as a regular part of your process? Interested but not sure?

Join us tomorrow morning to learn more! @dhtech_group
is working toward #DigitalHumanities community code review, and you can get involved.

RT @dhtech_group

You develop code for DH? How do you get feedback for your work? In a team of one! Join our next @ADHOrg
SIG DHtech Meetup to discuss the benefits of code review as a practice of DH. Meeting tomorrow Thursday May 25 at 9am ET/3pm CET on zoom, register here https://asu.zoom.us/meeting/register/tZYlfuqtpjsoHtbnARTnnRt-fkga8dyfSU5N#/registration

Do you have a proper code review process for pushing changes to data projects?

With ELT and dbt, small changes to code can have a big impact on downstream models. The last thing you want is to push a breaking change to prod 😱

Why you need code review for you data projects
by Balu Rama Chandra

https://medium.com/inthepipeline/why-you-need-code-review-for-you-data-projects-95e039083df0

#DataEngineering #DataQuality #DataOps #CodeReview #dbt #AnalyticsEngineering

#DEFCONTRAINING Las Vegas Spotlight

Join Ken Johnson and @sethlaw for their training "Practical Code Review"

From the abstract "This course introduces a proven methodology and framework for performing a secure code review, as well as addressing common challenges in modern secure code review. Short circuit your development of a custom secure code review process by gleaning from Seth & Ken's past adventures in performing hundreds of code reviews and the lessons we’ve learned along the way. We will share a proven methodology to perform security analysis of any source code repository and suss out security flaws, no matter the size of the code base, or the framework, or the language."

#defcon #defcon31 #codereview

Let’s post this great ressource on #codereview, so I can dig it in my history at some point.

You might also enjoy the read 😉

https://www.mediawiki.org/wiki/Guidelines_for_a_healthy_code_review_culture

A community member is looking for #codereview on a #JSON log formatter for #Python. Is this approach sound? You can post an answer addressing some or all of the (small) body of code shown; this isn't conventional Q&A where you need to have "the answer". Can you help? https://software.codidact.com/posts/288091

Hey academics, those of us who got good tenure news this year would benefit from your best advice for #AssociateProfessors

What do you wish you'd known or done?

Some of my challenges at the moment involve the transition to working with larger groups of students and needing to find ways to scale up mentoring and pursue some projects where I have a less hands-on role than I'm used to.

(My best tip for others in that regard: #CodeReview on every project!)

@academicchatter