Wow, #cppcheck actually found a real issue for a change: I was calling a virtual method from a destructor (this is #Cpp code). And of course, after staring at it for a minute, I realized I don't need that method to be virtual at all :)

(I intended this toot to be snarky and to say that it's the first time cppcheck found anything of importance, but I double-checked and it turns out it found me a different issue back in 2016. Considering I didn't pay a dime for this tool, the ROI is great.)

A small contribution to static analysis tool #Cppcheck from Codethink engineer Michael Drake: https://github.com/danmar/cppcheck/pull/4757

#OpenSource #Testing #StaticAnalysis #UpstreamFirst