Huh is #Gerrit Hiemstra al 62??? https://nos.nl/artikel/2488748-eigen-storm-voor-vertrekkend-weerman-gerrit-hiemstra

My first full day working on a project that uses #Gerrit (via gerrithub.io) for #GitHub #codereview and I'm pretty pleased with the workflows, and the clarity with which I can see The Things I Need To Do.
I know the team put a /lot/ of effort into tooling, workflows, and the glue to join them together, so my experience is hardly surprising, but it's still nice to be working with folks who care about that stuff; whereas many teams don't even /know/ what's possible in this space! #git

@larsmb Some have the opposite view really. #gerrit has the same process.

Github: fork, clone, create branch, pile up patches, push branch, open web browser, ask for merge request which has the list of commits.

Gerrit: clone, create branch, pile up patches, push to the special refs/for/<name of target branch>/<topic>, creates one change per commit tagged with <topic>

An advantage is you can get the first commit merged and you do not have to force push updates.

@theresnotime Cause it is not a wiki! Your comment is stored in git which does not play well with rewriting history. Then maybe the edit can be made a new comment with some logic to instruct to discard the old one. That would need a bunch of code for sure :) #gerrit

It looks like there's a new feature (well, new to me… maybe I'm just not very observant) in #GitHub that defaults the squash commit message to the *title and description* of the PR. This more closely matches #Gerrit, where the final commit message is changed along with other interim patchsets.

Late evenings hacking are the best. I have completed a prototype to integrate #patchdemo within #gerrit check UI https://phabricator.wikimedia.org/T332474#8874936

The #gerrit interface makes so much more sense if you see it as a fancy mailing list, with assistance for referencing code and tracking comment threads through multiple "mails".

Any #gerrit admins here? That I could pick your brain about a config issue?

The main thing I don’t like about #Gerrit is the voting system. If you want to request a change on a pull request, you have to slap a “−1” vote on someone’s work. It feels like you’re being graded, and that someone is telling you that you suck. Github’s wording (“changes requested”) is nicer.

And somewhere between two versions of Gerrit, the text input started saying “Say something nice…”. Why? Did something in the UI foster toxic behavior in the first place?

Help me webdev, you're my only hope!

I'd really like to fix some UI issues for me in #Gerrit using a #javascript #userScript via #tamperMonkey, but Gerrit seems quite resistant to this.

When I go to https://review.spdk.io/gerrit/q/status:open+-is:wip and pop open a console:

document.getElementsByClassName("selectionLabel")

gives back an empty collection. The devtools inspector disagrees (see pic). What is preventing me from finding these elements?

#daily #picture #gerrit

@fazzaro @qcoding I have to say that the #gerrit review flow has been great for teamwork. http://gerrit.appinventor.mit.edu/Documentation/intro-quick.html

Here is a new video showing how #Zuul and #Gerrit can be used to test and merge simultaneous changes to multiple #git repos. It's a great alternative to using monorepos for complex projects:

https://www.youtube.com/watch?v=B64RbNwkIa4

📌Android Software Engineer (m/f/d)
🏢 ParadoxCatGmbH
📍Munich

✅Degree in computer science, or a comparable qualification
✅Experience with #AOSP & #Gerrit
✅ 12+ months experience developing with #Android, #Kotlin, #Java, C++,Python

https://www.droidcon.com/job/paradox-cat-gmbh-munich-90-android-software-engineer-f-m-d/

📌Android Software Engineer (m/f/d)
🏢 ParadoxCatGmbH
📍Munich

✅Degree in computer science, or a comparable qualification
✅Experience with #AOSP & #Gerrit
✅ 12+ months experience developing with #Android, #Kotlin, #Java, C++,Python

https://www.droidcon.com/job/paradox-cat-gmbh-munich-90-android-software-engineer-f-m-d/

I will probably never remember to click the correct thing to merge my change. #gerrit

#Gerrit code review tools (comments, diffs) are nice but workflow is fucking garbage. It requires you to constantly squash changes. I actually keep separate branch for reviews but it's still PITA, even with help of scripts.

Ce soir pour le @parisjug@twitter.com "Young Blood" je parle de Vet, le client #Gerrit développé par @alaouirda@twitter.com chez @Cosium@twitter.com : Gerrit is fantastic, use Vet to get it! https://parisjug.org/xwiki/wiki/oldversion/view/Meeting/20190108
#java #java9 #jlink #Git

@lthms It's OK, but it keeps track of a lot of things that a simple mailing list does not - when you're talking about thousands of changes a day, just trying to keep track of some metadata, discussions and user info becomes a burden.

I love #Gerrit though! I really like how it helps you shape every *single* commit so your commit history ends up actually being useful.

@Wolf480pl@niu.moe

Ouch, that seems like a poor "feature" for #gerrit to have! I'd think handling it all as a single PR would be a lot better—for one thing, it wouldn't waste the resources for separate CI jobs. Plus, there are many times when it wouldn't even make *sense* to approve one commit without approving the others in the same PR.

The more I think about it, the odder that gets. I wonder why they did that?